Promote Relay artifacts into manifest - #19
Merged
AjayThorve merged 4 commits intoJun 26, 2026
Conversation
Signed-off-by: Ajay Thorve <athorve@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe runtime now promotes selected Relay stdout artifacts into each run’s artifact manifest after parsing stdout once, and the Relay smoke test now checks for those promoted manifest artifacts. ChangesRelay artifact promotion
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
AjayThorve
marked this pull request as ready for review
June 25, 2026 23:49
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/fabric-core/src/runtime.rs`:
- Around line 1228-1233: Ensure promoted artifact names in the manifest stay
unique when pushing to manifest.artifacts. The current artifact creation in the
relay promotion path uses relay_{kind} for every match, which can collide for
multiple entries of the same kind and make lookups ambiguous. Update the logic
around the ArtifactRef push so either only one artifact per kind is allowed or
the name is made unique using a filename- or index-based suffix before inserting
it.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 3a0720f2-ef95-4440-b751-6baea26f41dc
📒 Files selected for processing (2)
crates/fabric-core/src/runtime.rstests/smoke_relay_integration.py
Signed-off-by: Ajay Thorve <athorve@nvidia.com>
Signed-off-by: Ajay Thorve <athorve@nvidia.com>
dagardner-nv
approved these changes
Jun 26, 2026
Signed-off-by: Ajay Thorve <athorve@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ArtifactManifest.artifacts.output.relay_artifactsunchanged for compatibility.Validation
cargo test -p fabric-coreRUN_FABRIC_RELAY_INTEGRATION=1 python3 tests/smoke_relay_integration.pycargo testpython3 tests/smoke_cli.pyCloses FABRIC-20.
Summary by CodeRabbit
atof/atifartifacts are now promoted into run results and the artifact manifest withrelay_<kind>naming, including automatic suffixing for duplicates, and correct media types.